https://bugzilla.redhat.com/show_bug.cgi?id=1579045 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> --- This looks much better, thanks. There's one thing you need to fix before importing the package -- avoid expanding macros in the changelog: -- Drop "%defattr" tag as it's obsolete -- Add "BuildRequires: /usr/bin/git" (due to %autosetup -S git) +- Drop "%%defattr" tag as it's obsolete +- Add "BuildRequires: /usr/bin/git" (due to %%autosetup -S git) No need to block the review for this, the package is now APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/G7EOFAIUMETVTW3N74DNREK3Y66V2R4H/
