[Bug 1578151] Review Request: perl-Mojo-Pg - Mojolicious ♥ PostgreSQL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1578151



--- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> ---
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add run-requires
>      perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and
> Makefile.PL:33)

Done.

> TODO: Please consider adding following versioned run-requires
> (Makefile.PL:33)
>      perl(DBD::Pg) >= 3.005001

I've used the version 3.5.1 since that's the format the perl-DBD-Pg package
uses.

>      perl(Mojolicious) >= 7.53

Grumble... Done.

> Please correct all 'FIX' issues and consider fixing 'TODO' items.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Mojo-Pg/perl-Mojo-Pg-4.08-2.fc28.src.rpm

> Otherwise the package looks good.
> Approved

Thank you for the review, Jitka.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux