https://bugzilla.redhat.com/show_bug.cgi?id=1576792 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use a more meaningful archive name with: Source0: https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-%{version}.tar.gz - If you only plan to support Fedora >= 28, you could use the new "%?python_enable_dependency_generator" instead of specifying the Requires manually. See https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators - Generally we start numbering patch at 0 - I think you should name this package python-webthing and provide a Python 3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing > python-webthing.spec and then adjust the patch, license, description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx