Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: quicksynergy - GTK frontend for synergy https://bugzilla.redhat.com/show_bug.cgi?id=252133 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-07 04:10 EST ------- Hello, Andrew: Well, I must say there are some issues to be fixed on your spec file. You can check how to write your spec file on the following URL. Please read them first. http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines A. Description stage: * SourceURL - For sourceforge source, please refer to: http://fedoraproject.org/wiki/Packaging/SourceURL * BuildRequires - "gcc" is in the "expection" of BuildRequires (see "Exceptions" of http://fedoraproject.org/wiki/Packaging/Guidelines ) B. %prep/%build/%install stage * Macros - Please use macros properly http://fedoraproject.org/wiki/Packaging/RPMMacros For example, /usr/bin should be %{_bindir}. * Debuginfo issue http://fedoraproject.org/wiki/Packaging/Debuginfo - Please don't strip binaries by yourself. Stripping binaries disables to create debuginfo rpm. * Timestamp - Please keep timestamp. When using "install" command, add "-p" option. * desktop-file-install - Desktop file must be installed by using "desktop-file-install" ("BuildRequires: desktop-file-utils" is needed) - Note: Category "Application" is deprecated and should be removed (please check "desktop-file-install" usage). * GTK+ icon - For 48x48 desktop icon, please move it to %_datadir/icons/hicolor/48x48/apps and call gtk-update-icon-cache (please check: "GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) C. scriptlets * update-desktop-database - The included desktop file does not contain any mime type and calling "update-desktop-database" is not needed. D. %files entry * Documents - File "INSTALL" is for people who want to compile and install this package by themselves and not needed for people installing this package by using rpm. * gettext .mo file - Gettext .mo files should be installed by using %find_lang. Check the section "Handling Locale Files" of http://fedoraproject.org/wiki/Packaging/Guidelines Other things are: * Rebuild - Rebuild itself fails. http://koji.fedoraproject.org/koji/taskinfo?taskID=150879 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review