https://bugzilla.redhat.com/show_bug.cgi?id=1575601 --- Comment #4 from Artur Iwicki <fedora@xxxxxxxxxx> --- I'm not sure why you have three %defines at the top for the name, version and release. If you put them in the tags (like "Version: 0.1"), you can use the macros (e.g. "%{version}") later on without any issues. >Release: 39.g764645d This should end with the dist tag (e.g. "f27") - use "%{?dist}". >%setup -n beakerlib-libraries It's recommended to use a "quiet setup" - use the -q option. >%install >rm -rf %{buildroot} Do not remove the buildroot at start of %install. [1] >%clean >rm -rf $RPM_BUILD_ROOT Drop the %clean section completely. [1] >rm -rf %{buildroot} >rm -rf $RPM_BUILD_ROOT Do not mix usages of %{buildroot} and $RPM_BUILD_ROOT. Pick one and stick to it. [2] >cp -rf * %{buildroot}%{libraries_path} Use the -p option to preserve timestamps. [3] There are some scripts (.sh) installed which do not have the executable bit set: [4] /usr/share/beakerlib-libraries/authconfig/Library/basic/lib.sh /usr/share/beakerlib-libraries/bind/Library/bind-setup/lib.sh /usr/share/beakerlib-libraries/distribution/Library/Cleanup/lib.sh /usr/share/beakerlib-libraries/distribution/Library/Log/lib.sh /usr/share/beakerlib-libraries/distribution/Library/RpmSnapshot/lib.sh /usr/share/beakerlib-libraries/distribution/Library/dpcommon/lib.sh /usr/share/beakerlib-libraries/distribution/Library/dump/lib.sh /usr/share/beakerlib-libraries/distribution/Library/epel/lib.sh /usr/share/beakerlib-libraries/distribution/Library/opts/lib.sh /usr/share/beakerlib-libraries/distribution/Library/sundry/lib.sh /usr/share/beakerlib-libraries/kernel/Library/base/lib-compat.sh /usr/share/beakerlib-libraries/kernel/Library/base/lib.sh /usr/share/beakerlib-libraries/nginx/Library/nginx/lib.sh /usr/share/beakerlib-libraries/openssl/Library/certgen/lib.sh /usr/share/beakerlib-libraries/openssl/Library/certgen/runtest.sh /usr/share/beakerlib-libraries/perl/Library/subpackage/lib.sh /usr/share/beakerlib-libraries/php/Library/utils/lib.sh /usr/share/beakerlib-libraries/samba/Library/samba-bits/lib.sh /usr/share/beakerlib-libraries/sos/Library/utils/lib.sh /usr/share/beakerlib-libraries/squid/Library/squid/lib.sh /usr/share/beakerlib-libraries/tuned/Library/basic/lib.sh /usr/share/beakerlib-libraries/yum/Library/common-functions/lib.sh There's also a single .c file with the executable bit set: [4] /usr/share/beakerlib-libraries/kernel/Library/base/src/expendfdrun/expendfdrun.c You should also add %changelog entries when making changes. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS [3] https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps [4] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
