[Bug 1534052] Review Request: golang-github-mdlayher-netlink - Package netlink provides low-level access to Linux netlink sockets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1534052

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #9 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Paul Gier from comment #8)
> Thanks!  I have made the requested changes, and a new build is here:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=26861566
> 
> I had disabled the tests because one of the was failing locally using
> upstream sources.  I created a patch to skip the failing test and re-enabled
> the checks in the specfile.
> 
> Is it correct to specify the arches using this?
> ExclusiveArch: %{go_arches}
> 
Not needed, %gometa already takes care of that.

> I also had to exclude the s390x arch due to failing tests.

Report the failing tests upstream. Also per the guidelines, you'll need to
create a bugreport for this, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures

 - Reduce the Summary size and remove the dot at the end:

golang-github-mdlayher-netlink-devel.x86_64: W: summary-ended-with-dot C
Package netlink provides low-level access to Linux netlink sockets. MIT
Licensed.
golang-github-mdlayher-netlink-devel.x86_64: E: summary-too-long C Package
netlink provides low-level access to Linux netlink sockets. MIT Licensed.

 - Split the description to stay below 80 characters per line:

golang-github-mdlayher-netlink-devel.x86_64: E: description-line-too-long C
Package netlink provides low-level access to Linux netlink sockets. MIT
Licensed.

 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines


Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux