https://bugzilla.redhat.com/show_bug.cgi?id=1575008 --- Comment #5 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> --- Spec URL: http://david.woodhou.se/pidgin-chime.spec SRPM URL: http://david.woodhou.se/pidgin-chime-0.95-1.fc28.src.rpm Thanks for the review. (In reply to Robert-André Mauchin from comment #3) > - Latest version is 0.94 0.95 now; I'm tagging "releases" as I go, for testing. When the review is done and I'm ready to do a proper build, I'll call it 1.0. > - Group: is not needed > - %defattr(-,root,root,-) is not needed Removed. > - Source0: should be a URL, like: > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Fixed. > - The snapshot info should be in Release, not Version: I'm not doing snapshots for the real Fedora package builds; I'll always tag a proper release before building in Fedora. The snapshot support in the specfile is just for the COPR which autobuilds each github commit. I'll rip it out completely for the real builds. FWIW that's what rpkg does with its {{{git_version}}} macro, which COPR seems to be pushing us to use these days. (In reply to Robert-André Mauchin from comment #4) > - In %files: /etc → %{_sysconfdir} Done. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
