https://bugzilla.redhat.com/show_bug.cgi?id=1575257 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: Group: Development - Apache-2.0 is not a valid license shorthand, use "ASL 2.0". See full list: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses - Use %global instead of %define: %global rel swift-%{version}-RELEASE It should generally be located in the header for clarity - Also use a Release instead of a Development snapshots, latest is: https://github.com/apple/swift-llbuild/releases/tag/swift-4.1.1-RELEASE - Split your BR one per line BuildRequires: clang cmake ncurses-devel sqlite-devel - Spit your description to stay below 80 characters per line: %description llbuild is a set of libraries for building build systems. Unlike most build system projects which focus on the syntax for describing the build, llbuild is designed around a reusable, flexible, and scalable general purpose build engine capable of solving many "build system"-like problems. The project also includes additional libraries on top of that engine which provide support for constructing bespoke build systems (like swift build) or for building from Ninja manifests. - The licence file must be installed with %license not %doc: %doc CONTRIBUTING.md README.md %license LICENSE.txt - You're installing a library in %{_libdir}, you must run %ldconfig_scriptlets after %install - Add your own changelog entry: %changelog * Sat May 05 2018 Sascha Peilicke <sascha@xxxxxxxxxxx> - 4.1.1-1 - Initial RPM release - pass build flags to cmake, they need to be tweaked because of clang %global fixed_set_build_flags echo '%set_build_flags' | sed 's/-mcet -fcf-protection//' %fixed_set_build_flags CC=$(which clang) CXX=$(which clang++) %__cmake .. \ -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \ -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \ -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \ -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ -DCMAKE_INSTALL_PREFIX:PATH=%{_prefix} \ -DINCLUDE_INSTALL_DIR:PATH=%{_includedir} \ -DLIB_INSTALL_DIR:PATH=%{_libdir} \ -DSYSCONF_INSTALL_DIR:PATH=%{_sysconfdir} \ -DSHARE_INSTALL_PREFIX:PATH=%{_datadir} \ %if "%{?_lib}" == "lib64" %{?_cmake_lib_suffix64} \ %endif -DBUILD_SHARED_LIBS:BOOL=ON Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
