[Bug 1573695] Review Request: battray - simple tray icon to show a laptop’s battery status.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1573695



--- Comment #7 from Ranjan Maitra <itsme_410@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #6)
> You removed the BR and RR, why? Xoi need python3-devel
> 
>  - Depends on python3-devel:
> 
> BuildRequires:  python3-devel
> BuildRequires:  python3-setuptools

I also thought so, but I took python3-devel out (also uninstalled in my local
machine) and recompiled and it works just fine from what I can tell (for me).
Is this still needed?

> 
>  - There's no python-gobject, it should be:
> 
> Requires:       python3-gobject

Same story here: removing it seems to do fine without it. I can't notice any
ill-effect.

>  - Also, split the descirption to stay below 80 characters per line:
> 
> %description
> Battray is a fairly simple tray icon to show a laptop’s battery status. It’s 
> simple, easy, fairly environment-independent, and ‘just works’ without tons
> of 
> {Gnome,KDE,..} dependencies.
> 
> One can also configure it to play annoying sounds if your battery is getting 
> low, dim the screen when you switch from AC to battery, etc.
> 
>  - You have a mix of tabs and spaces, use either tabs or spaces but not both
> at the same time.

OK, will fix these, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux