https://bugzilla.redhat.com/show_bug.cgi?id=1558683 --- Comment #13 from Alfredo Moralejo <amoralej@xxxxxxxxxx> --- (In reply to Sandhya Dasu from comment #12) > (In reply to Alfredo Moralejo from comment #11) > > Some notes: > > > > - Missing Requires on python2-pyparsing for python2-ucsmsdk package. > Updating ucsmsdk with requirements.txt containing pyparsing. Will upload > another RPM shortly. > > - Does ucsmsdk support python3?, i'm trying to run unit tests in Fedora with > > python3 and it's failing. We should build the package for python2 and > > python3 as fedora is moving to it. > > Yes, does support Python3. Will build package for both python2 and python3. > > > - It'd be nice to run unit tests in %check section of the spec if possible > > (you can look at > > https://src.fedoraproject.org/rpms/python-kubernetes/blob/master/f/python- > > kubernetes.spec for example) > > Just spoke to original authors of ucsmsdk. UTs currently require access to a > valid UCSM domain (UCSM or an emulator) for them to pass. ok, then, we can skip then. However, by definition, unit tests should not be influenced by external conditions which should be mocked. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
