Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flashrom - Simple program for reading/writing BIOS chips content https://bugzilla.redhat.com/show_bug.cgi?id=250924 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx ------- Additional Comments From opensource@xxxxxxxxx 2007-09-06 10:30 EST ------- This seems to be a pre release snaphsot, so the release should start with 0. Also you can use 0 for the Version instead of 0.0. So here is my proposal: Version: 0 Release: 0.1.<date>svn2744%{?dist} You should also include the date of the checkout, see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages If the checkouts you want to package are normally more than a day old, you can also use the date to specify which version you want to checkout, e.g. svn -r "{20070901}" export svn://linuxbios.org/repos/trunk/util/flashrom flashrom Then you do not need to carry the svn revision. Hint: # svn -r 2744 co svn://linuxbios.org/repos/trunk/util/flashrom flashrom # rm -rf flashrom/.svn you can use svn export instead of co to avoid the creation of the .svn directory. You should use install -D -p -m644 %{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1 to install the manpage (-p is added here) to preserve the timestamp. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review