Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: sed https://bugzilla.redhat.com/show_bug.cgi?id=226404 ------- Additional Comments From mlichvar@xxxxxxxxxx 2007-09-06 05:11 EST ------- - rpmlint is silent - the package is named according to the Package Naming Guidelines - the spec file name matches the base package %{name} X the package must meet the Packaging Guidelines - please remove glibc from requires and buildrequires, and remove version from the glibc-devel buildrequirement as newer glibc packages are in currently supported releases - consider changing URL to http://sed.sourceforge.net/ - add -p option to preserve the timestamp for sedfaq - replace %makeinstall with make DESTDIR=... - the package is licensed with a Fedora approved license - the License field in the package spec file matches the actual license (GPLv2+) X if the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc - please add COPYING and COPYING.DOC to %doc - the spec file is written in American English - the spec file for the package is legible - the sources used to build the package matches the upstream source X all build dependencies must be listed in BuildRequires - gawk is missing (until FESCo approves a new package listing for buildroot) - the spec file handles locales properly - the package owns all directories that it creates - the package does not contain any duplicate files in the %files listing - permissions on files are set properly - the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT - the package consistently uses macros - the package contains code, or permissible content - files included as %doc don't affect the runtime of the application - the package does not own files or directories already owned by other packages - at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT - all filenames in rpm packages are valid UTF-8 - scriptlets are sane -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review