Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mondo https://bugzilla.redhat.com/show_bug.cgi?id=187318 ondrejj@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ondrejj@xxxxxxxxxx ------- Additional Comments From ondrejj@xxxxxxxxxx 2007-09-06 03:44 EST ------- rpmlint says: W: mondo invalid-license GPL E: mondo non-utf8-spec-file mondo.spec W: mondo macro-in-%changelog attr W: mondo macro-in-%changelog done W: mondo macro-in-%changelog d Please change license to GPLv2 or GPLv2+ . Convert your spec file to UTF-8. Remove macros (%attr, %done, %d) from changelog entries, you can remove the "%" sign and leave only the "attr macro" string. Your localized summary lines are too loing. They can be only 80 characters long. The ".fc7" tag is hardcoded into spec file. Please change it to "%{?dist}". Update changelog entries to more Fedora notation. Change this: * Fri Jul 06 2007 Bruno Cornec <bruno@xxxxxxxxxxxxxxx> 2.2.4-1.fc7 to: * Fri Jul 06 2007 Bruno Cornec <bruno@xxxxxxxxxxxxxxx> - 2.2.4-1.fc7 ("-" sign has been added) I think your changelog is too long and may be reduced. I think svn.log is not needed in package documentation, ChangeLog is enough. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review