[Bug 1572183] Review Request: perl-Menlo-Legacy - Legacy internal and client support for Menlo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1572183

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
987c57435b822856fe539694aacc721253e87b37ef973d9dd65074184bc6f6a6) is original.
Ok.
Summary verified from lib/Menlo/Legacy.pm. Ok.
Description verified from lib/Menlo/Legacy.pm. Ok.
License verified from lib/Menlo/Legacy.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Menlo-Legacy.spec
review-perl-Menlo-Legacy/results/perl-Menlo-Legacy-1.9019-1.fc29.noarch.rpm
review-perl-Menlo-Legacy/results/perl-Menlo-Legacy-1.9019-1.fc29.src.rpm      
perl-Menlo-Legacy.noarch: W: spelling-error %description -l en_US Compat -> Com
pat, Com-pat, Compact
perl-Menlo-Legacy.noarch: W: spelling-error %description -l en_US cpanminus ->
minuscules
perl-Menlo-Legacy.noarch: W: spelling-error %description -l en_US behavios ->
behaviors, behavior
perl-Menlo-Legacy.noarch: W: spelling-error %description -l en_US cpanm ->
panama
perl-Menlo-Legacy.noarch: W: spelling-error %description -l en_US cpm -> com,
cm, pm
perl-Menlo-Legacy.src: W: spelling-error %description -l en_US Compat -> Com
pat, Com-pat, Compact
perl-Menlo-Legacy.src: W: spelling-error %description -l en_US cpanminus ->
minuscules
perl-Menlo-Legacy.src: W: spelling-error %description -l en_US behavios ->
behaviors, behavior
perl-Menlo-Legacy.src: W: spelling-error %description -l en_US cpanm -> panama
perl-Menlo-Legacy.src: W: spelling-error %description -l en_US cpm -> com, cm,
pm
2 packages and 1 specfiles checked; 0 errors, 10 warnings.

$ rpm -q -lv -p perl-Menlo-Legacy-1.9019-1.fc29.noarch.rpm 
drwxr-xr-x    2 root    root                        0 avril 26 17:29
/usr/share/doc/perl-Menlo-Legacy
-rw-r--r--    1 root    root                       93 avril 25 11:15
/usr/share/doc/perl-Menlo-Legacy/Changes
-rw-r--r--    1 root    root                      825 avril 25 11:15
/usr/share/doc/perl-Menlo-Legacy/README
drwxr-xr-x    2 root    root                        0 avril 26 17:29
/usr/share/licenses/perl-Menlo-Legacy
-rw-r--r--    1 root    root                    18442 avril 25 11:15
/usr/share/licenses/perl-Menlo-Legacy/LICENSE
-rw-r--r--    1 root    root                     1313 avril 26 17:29
/usr/share/man/man3/Menlo::CLI::Compat.3pm.gz
-rw-r--r--    1 root    root                     1543 avril 26 17:29
/usr/share/man/man3/Menlo::Legacy.3pm.gz
drwxr-xr-x    2 root    root                        0 avril 26 17:29
/usr/share/perl5/vendor_perl/Menlo
drwxr-xr-x    2 root    root                        0 avril 26 17:29
/usr/share/perl5/vendor_perl/Menlo/CLI
-rw-r--r--    1 root    root                    87005 avril 25 11:15
/usr/share/perl5/vendor_perl/Menlo/CLI/Compat.pm
-rw-r--r--    1 root    root                      952 avril 25 11:15
/usr/share/perl5/vendor_perl/Menlo/Legacy.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Menlo-Legacy-1.9019-1.fc29.noarch.rpm | sort -f |
uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Archive::Tar)
      1 perl(Archive::Zip)
      1 perl(Capture::Tiny)
      1 perl(Config)
      1 perl(constant)
      1 perl(CPAN::Common::Index::LocalPackage)
      1 perl(CPAN::DistnameInfo)
      1 perl(CPAN::Meta)
      1 perl(CPAN::Meta::Check)
      1 perl(CPAN::Meta::Requirements)
      1 perl(CPAN::Meta::YAML)
      1 perl(Cwd)
      1 perl(Digest::SHA)
      1 perl(ExtUtils::Manifest)
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Find)
      1 perl(File::HomeDir)
      1 perl(File::Path)
      1 perl(File::pushd)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(File::Which)
      1 perl(Getopt::Long)
      1 perl(HTTP::Tinyish)
      1 perl(JSON::PP)
      1 perl(local::lib)
      1 perl(Menlo) >= 1.9018
      1 perl(Menlo::Builder::Static)
      1 perl(Menlo::Dependency)
      1 perl(Menlo::Index::MetaCPAN)
      1 perl(Menlo::Index::MetaDB)
      1 perl(Menlo::Index::Mirror)
      1 perl(Menlo::Util)
      1 perl(Module::CoreList)
      1 perl(Module::CPANfile)
      1 perl(Module::Metadata)
      1 perl(Module::Signature)
      1 perl(Parse::PMFile)
      1 perl(Safe)
      1 perl(strict)
      1 perl(Symbol)
      1 perl(version)
      1 perl(version::vpp)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Menlo-Legacy-1.9019-1.fc29.noarch.rpm 
perl(Menlo::CLI::Compat) = 1.9019
perl(Menlo::Legacy) = 1.9019
perl-Menlo-Legacy = 1.9019-1.fc29
Binary provides are Ok.


Package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=26578210)
Ok

 - Installation error:

DEBUG util.py:482:  BUILDSTDERR: Error: Transaction check error:
DEBUG util.py:482:  BUILDSTDERR:   file
/usr/share/perl5/vendor_perl/Menlo/CLI/Compat.pm conflicts between attempted
installs of perl-Menlo-Legacy-1.9019-1.fc29.noarch and
perl-Menlo-1.9018-1.fc29.noarch

I assume this will be solved with perl-Menlo-1.9019.

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux