[Bug 1572084] Review Request: colin - Tool to check generic rules/ best-practices for containers/images/dockerfiles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1572084

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - [!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/colin

   Fix this by removing the asterisk:

%{_datadir}/%{pypi_name}/

 - Use the new %{?python_enable_dependency_generator} to generate the Requires
automatically. Note that it will add python3.6dist(conu) >= 0.3.0rc0 as a
Requires, so you may need to update that package first.

 - Simply use "doc" as a package name:


%package doc
Summary:        colin documentation

%description doc
Documentation for colin.

%files doc


 - Build the doc with Sphinx instead of packaging the source files:

BuildRequires:  python3-sphinx

   And:

%build
%py3_build

make html
rm build/html/.{doctrees,buildinfo}

   Then install them in %files:

%files doc
%license LICENSE
%doc build/html

   It seems the Makefile(s) are missing from the archive, either grab the
source from Github or ask upstream to fix their archive.

Source0:        %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz

 - Running the tests would be nice too

 - Remove the dot at the end of summary:

colin.noarch: W: summary-ended-with-dot C Tool to check generic
rules/best-practices for containers/images/dockerfiles.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux