[Bug 1571287] Review Request: python-lightblue - A Python library to work with Lightblue database API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1571287

Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(sochotni@redhat.c |
                   |om)                         |



--- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> ---
(In reply to Lubomír Sedlář from comment #1)
> Why the conditional for Python 3 subpackage? Where do you want to build it
> without that?

EPEL 7

> The macros in Summary are wrong, the subpackages end up with this:
> $ rpm -qp --queryformat '%{Summary}\n'
> results/python2-lightblue-0.1.3-1.fc26.noarch.rpm 
> %{Summary}
> Also rpmlint complains about this unexpanded macro.

Right, will fix

> You should ask upstream to include LICENCE file in the tarball so that it
> can be installed.

Already done and merged: https://github.com/Allda/python-lightblue/pull/5
But won't be done until next release

> You might want to use %{srcname} in Name, but that's a detail.

Yeah, I should.

Will fix the summary part for now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux