Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bluez-firmware - Bluetooth firmware distributed by the BlueZ project https://bugzilla.redhat.com/show_bug.cgi?id=258681 ------- Additional Comments From opensource@xxxxxxxxx 2007-09-05 17:31 EST ------- - rpmlint: ok E: bluez-firmware hardcoded-library-path /lib in configure options this is intended and ok here. - Naming: ok - license: bad There is no indication that this package is redistributable, there is only contact information for the broadcom firmware but no information at all for the ST Microelectronics firmware. I guess this review should block FE-Legal or you should make upstream include license information for the firmware that states that redistribution is allowed. The link to packages.debian.org is imho not enough. 1cc3cefad872e937e05de5a0a2b390dd bluez-firmware-1.2.tar.gz 1cc3cefad872e937e05de5a0a2b390dd bluez-firmware-1.2.tar.gz.1 Suggestion: You can use %%{_lib} in %changelog to show the full name of the _lib macro. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review