Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |opensource@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From opensource@xxxxxxxxx 2007-09-05 16:49 EST ------- The release should be an integer, imho it is in the Naming Guidelines (http://fedoraproject.org/wiki/Packaging/NamingGuidelines) So change Release: 9.2%{?dist} to Release: 10%{?dist} You can later use Release: 10%{?dist}.1 If you need to increment only in one Fedora Collection that is not Rawhide. Source0 is not valid (anymore): $ curl -I http://forgeftp.novell.com/flaim/development/flaim/downloads/source/libflaim-4.9.1046.tar.gz HTTP/1.1 404 Not Found According to the URL in the spec file the latest tarball is: libflaim-4.9.989.tar.gz Is this older version intentional? The buildroot is not ok, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 You should use %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) or some other example from the wiki. Please use rm -rf %{buildroot} instead of rm -Rf %{buildroot} Did you build your packages with mock? When I build it and run rpmlint on the rpms, I get: $ rpmlint libflaim-* W: libflaim unstripped-binary-or-object /usr/lib/libflaim.so.5.2 E: libflaim-debuginfo empty-debuginfo-package W: libflaim-devel no-documentation The third warning can be ignored. The build.log shows: ldconfig /var/tmp/libflaim-4.9.1046-build/usr/lib Installation complete. + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/libflaim-4.9.1046 0 blocks find: /var/tmp/libflaim-4.9.1046-build/usr/lib/debug: No such file or directory But I do not know, why. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review