https://bugzilla.redhat.com/show_bug.cgi?id=1570557 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source archive (SHA-256: 3d1f46365892c5b43adcadac296c9bc831374b282baf9e1eb8187f643facf5f0) is original. Ok. Summary verified from lib/Command/Runner.pm. Ok. Description verified from lib/Command/Runner.pm. Ok. TODO: Expand `refs' in the summary and the description to `references'. License verified from LICENSE and lib/Command/Runner.pm. Ok. No XS code, noarch BuildArch is Ok. FIX: Because Win32::ShellQuote is not available, t/02_basic.t is skipped and thus there is no point in build-requiring String::ShellQuote. Don't build-require String::ShellQuote or, rather patch out the "use Test::Needs 'Win32::ShellQuote';" code and report a bug to the upstream to load it only on Windows. All tests pass. Ok. $ rpmlint perl-Command-Runner.spec ../SRPMS/perl-Command-Runner-0.002-1.fc29.src.rpm ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm drwxr-xr-x 2 root root 0 Apr 23 11:11 /usr/share/doc/perl-Command-Runner -rw-r--r-- 1 root root 163 Apr 21 20:31 /usr/share/doc/perl-Command-Runner/Changes -rw-r--r-- 1 root root 2028 Apr 21 20:31 /usr/share/doc/perl-Command-Runner/README drwxr-xr-x 2 root root 0 Apr 23 11:11 /usr/share/licenses/perl-Command-Runner -rw-r--r-- 1 root root 18400 Apr 21 20:31 /usr/share/licenses/perl-Command-Runner/LICENSE -rw-r--r-- 1 root root 2785 Apr 23 11:11 /usr/share/man/man3/Command::Runner.3pm.gz -rw-r--r-- 1 root root 20 Apr 23 11:11 /usr/share/man/man3/Command::Runner::LineBuffer.3pm.gz drwxr-xr-x 2 root root 0 Apr 23 11:11 /usr/share/perl5/vendor_perl/Command drwxr-xr-x 2 root root 0 Apr 23 11:11 /usr/share/perl5/vendor_perl/Command/Runner -rw-r--r-- 1 root root 8313 Apr 21 20:31 /usr/share/perl5/vendor_perl/Command/Runner.pm -rw-r--r-- 1 root root 1151 Apr 21 20:31 /usr/share/perl5/vendor_perl/Command/Runner/LineBuffer.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(Capture::Tiny) 1 perl(Command::Runner::LineBuffer) 1 perl(Config) 1 perl(constant) 1 perl(IO::Select) 1 perl(POSIX) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(Command::Runner) = 0.002 1 perl(Command::Runner::LineBuffer) 1 perl-Command-Runner = 0.002-1.fc29 Binary provides are Ok. Package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=26511690). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item and consider fixing the `TODO' item before building the packages. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
