Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rpmrebuild - A tool to build rpm file from rpm database https://bugzilla.redhat.com/show_bug.cgi?id=252010 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-09-05 11:51 EST ------- Some remarks: * Your %install references /usr/lib/rpmrebuild/rpmrebuild_parser.src while your %files contains: %{_libdir}/rpmrebuild/rpmrebuild_parser.src This doesn't make a visible difference because your package is "noarch", nevertheless this is inconsistent. * The block-delete-/bin/sh magic in %postun can be replaced with a one-line sed-call: sed -e '/RPMREBUILD START/,/RPMREBUILD END/d' ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review