https://bugzilla.redhat.com/show_bug.cgi?id=1567819 --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: > [x]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/gocode/src, > /usr/share/gocode, /usr/share/gocode/src/github.com This is normal for gofed generated packages, so I'm giving a pass on this. And I expect this to be corrected with 3.0 spec format in the future. Also, at least a couple of those are owned by the golang stack itself, I believe. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 11 files have unknown license. Detailed > output of licensecheck in /home/makerpm/1567819-golang-github- > pilebones-go-udev/licensecheck.txt This is caused by none of the golang files actually having license headers. Sadly, this appears to be the norm in Go libraries (even though it's a bad idea with how people do vendoring), so I'm going to consider the license file as sufficient. > golang-github-pilebones-go-udev.x86_64: E: no-binary This is not terribly surprising, and I'm okay with ignoring this, since it's a false positive with how Go libraries are packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
