https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #9 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- When updating a package submission, it is really helpful to link to both the spec and SRPM in the following form: Spec URL: [link to latest spec] SRPM URL: [link to latest SRPM] Don't just link a koji build. That way the automatic review tool (the "fedora-review" package) can run over your submission. This is not a requirement but it's extremely helpful. :) Anyway; please either add bundled provides or unbundle the following additional nodejs modules too: [bjr@irune src]$ ls extension_tools/node_modules/ -l total 12 drwxrwxr-x 5 bjr bjr 4096 Apr 10 13:33 adm-zip drwxrwxr-x 4 bjr bjr 4096 Apr 10 13:33 archiver drwxrwxr-x 5 bjr bjr 4096 Apr 10 13:33 shelljs Further, nodejs-archiver has the following nodejs dependencies which are also bundled: [bjr@irune node_modules]$ ls archiver/node_modules/ -l total 32 drwxrwxr-x 4 bjr bjr 4096 Apr 10 13:33 async drwxrwxr-x 3 bjr bjr 4096 Apr 10 13:33 buffer-crc32 drwxrwxr-x 3 bjr bjr 4096 Apr 10 13:33 glob drwxrwxr-x 4 bjr bjr 4096 Apr 10 13:33 lazystream drwxrwxr-x 13 bjr bjr 4096 Apr 10 13:33 lodash drwxrwxr-x 4 bjr bjr 4096 Apr 10 13:33 readable-stream drwxrwxr-x 3 bjr bjr 4096 Apr 10 13:33 tar-stream drwxrwxr-x 4 bjr bjr 4096 Apr 10 13:33 zip-stream archiver, at least, is packaged in fedora as "nodejs-archiver". I would strongly encourage you to unbundle it due to the large nodejs dependency tree here. :) Additionally, if you don't unbundle things, you'll need to update the License: field accordingly with the licenses of the bundled packages. Looking at the output from licensecheck, I can see that a lot of the node modules are under the ISC, BSD, and MIT licenses: https://paste.fedoraproject.org/paste/KZco-kvQsCQcBRdAkap0mQ e.g.: BSD (2 clause) -------------- notepadqq-1.3.4/src/extension_tools/node_modules/shelljs/LICENSE BSD (3 clause) -------------- notepadqq-1.3.4/doc/api/theme/license/highlight.js/LICENSE ISC --- notepadqq-1.3.4/src/extension_tools/node_modules/archiver/node_modules/glob/LICENSE MIT/X11 (BSD like) ------------------ notepadqq-1.3.4/src/editor/libs/codemirror/LICENSE You can do this by writing, e.g. "License: GPLv3+ and MIT" for codemirror; see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios for more information. Another license-related comment: - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license You need to mark the "COPYING" file as %license in the files section. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
