[Bug 1568877] Review Request: perl-File-Copy-Recursive-Reduced - Recursive copying of files and directories within Perl 5 toolchain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1568877

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
da4ac403cb6b82fc9898d22cfd1e90481ac37804e0377d1f00fd4517d94a0f76) is original.
Ok.
Summary verified from lib/File/Copy/Recursive/Reduced.pm. Ok.
Description verified from lib/File/Copy/Recursive/Reduced.pm. Ok.
License verified from lib/File/Copy/Recursive/Reduced.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-File-Copy-Recursive-Reduced.spec
review-perl-File-Copy-Recursive-Reduced/results/perl-File-Copy-Recursive-Reduced-0.003-1.fc29.noarch.rpm
review-perl-File-Copy-Recursive-Reduced/results/perl-File-Copy-Recursive-Reduced-0.003-1.fc29.src.rpm 
perl-File-Copy-Recursive-Reduced.noarch: W: spelling-error Summary(en_US)
toolchain -> tool chain, tool-chain, Chaitin
perl-File-Copy-Recursive-Reduced.noarch: W: spelling-error %description -l
en_US fcopy -> copy, f copy
perl-File-Copy-Recursive-Reduced.noarch: W: spelling-error %description -l
en_US dircopy -> radioscopy
perl-File-Copy-Recursive-Reduced.noarch: W: spelling-error %description -l
en_US toolchain -> tool chain, tool-chain, Chaitin
perl-File-Copy-Recursive-Reduced.noarch: E: incorrect-fsf-address
/usr/share/licenses/perl-File-Copy-Recursive-Reduced/LICENSE
perl-File-Copy-Recursive-Reduced.src: W: spelling-error Summary(en_US)
toolchain -> tool chain, tool-chain, Chaitin
perl-File-Copy-Recursive-Reduced.src: W: spelling-error %description -l en_US
fcopy -> copy, f copy
perl-File-Copy-Recursive-Reduced.src: W: spelling-error %description -l en_US
dircopy -> radioscopy
perl-File-Copy-Recursive-Reduced.src: W: spelling-error %description -l en_US
toolchain -> tool chain, tool-chain, Chaitin
2 packages and 1 specfiles checked; 1 errors, 8 warnings.

Please notify upstream about the obsolete FSF address.

$ rpm -q -lv -p perl-File-Copy-Recursive-Reduced-0.003-1.fc29.noarch.rpm
drwxr-xr-x    2 root    root                        0 avril 18 15:14
/usr/share/doc/perl-File-Copy-Recursive-Reduced                                 
-rw-r--r--    1 root    root                      536 avril 17 15:14
/usr/share/doc/perl-File-Copy-Recursive-Reduced/Changes                         
-rw-r--r--    1 root    root                     1763 avril 17 15:11
/usr/share/doc/perl-File-Copy-Recursive-Reduced/README                          
-rw-r--r--    1 root    root                      243 avril 16 23:50
/usr/share/doc/perl-File-Copy-Recursive-Reduced/Todo                            
drwxr-xr-x    2 root    root                        0 avril 18 15:14
/usr/share/licenses/perl-File-Copy-Recursive-Reduced                            
-rw-r--r--    1 root    root                    20545 avril 11 04:05
/usr/share/licenses/perl-File-Copy-Recursive-Reduced/LICENSE                    
-rw-r--r--    1 root    root                     4354 avril 18 15:14
/usr/share/man/man3/File::Copy::Recursive::Reduced.3pm.gz                       
drwxr-xr-x    2 root    root                        0 avril 18 15:14
/usr/share/perl5/vendor_perl/File             
drwxr-xr-x    2 root    root                        0 avril 18 15:14
/usr/share/perl5/vendor_perl/File/Copy
drwxr-xr-x    2 root    root                        0 avril 18 15:14
/usr/share/perl5/vendor_perl/File/Copy/Recursive
-rw-r--r--    1 root    root                    15709 avril 17 15:13
/usr/share/perl5/vendor_perl/File/Copy/Recursive/Reduced.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-File-Copy-Recursive-Reduced-0.003-1.fc29.noarch.rpm
 | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Exporter)
      1 perl(File::Copy)
      1 perl(File::Find)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.


rpm -q --provides -p perl-File-Copy-Recursive-Reduced-0.003-1.fc29.noarch.rpm
perl(File::Copy::Recursive::Reduced) = 0.003
perl-File-Copy-Recursive-Reduced = 0.003-1.fc29
Binary provides are Ok.



Package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=26440036)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux