Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TzClock - GTK+ Time Zone Clock https://bugzilla.redhat.com/show_bug.cgi?id=253549 petersen@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |petersen@xxxxxxxxxx Summary|Review Request: TzClock - |Review Request: TzClock - |GTK+ Time Zone Clock |GTK+ Time Zone Clock ------- Additional Comments From petersen@xxxxxxxxxx 2007-09-05 04:23 EST ------- A few comment: - How about a desktop file? - Would be nice to use %configure and %{_bindir}. - changelog entry would be nice too - you should not use the Packager field in fedora packages: your name will be in the changelog - url to source tarball should be used - I would replace "X" by "Cairo" say in the Summary. You probably want to run rpmlint on the srpm and rpm to check for more things. Very cool clock! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review