https://bugzilla.redhat.com/show_bug.cgi?id=1380826 --- Comment #23 from Devrim Gündüz <devrim@xxxxxxxxxx> --- Hi Itamar, (In reply to Itamar Reis Peixoto from comment #20) > Hey Devrim, I am adding a new spec file + src.rpm on your behalf, please > take a look , > > > Spec URL: https://itamarjp.fedorapeople.org/review/pgadmin4.spec > SRPM URL: > https://itamarjp.fedorapeople.org/review/pgadmin4-3.0-1.fc28.src.rpm A few comments: * The unit file must be removed, it is not needed. * Community RPMs ship a shell script to configure pgAdmin for server mode: https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/pgadmin4-v3/master/pgadmin4-web-setup.sh;h=b2fedb2f149134277e7a155a396dda1edf4a0c20;hb=HEAD IMHO this script (or something similar) should be a part of Fedora RPMs as well * Per requirements.txt, hard dependeny versions should be added to each dependency (otherwise pgAdmin4 segfaults, if a dependency version is less than it should be) > > I am also created an copr repo with the stuff that's need to be added in > Fedora 28 at https://copr.fedorainfracloud.org/coprs/itamarjp/pgadmin4/ > > > what do you think about removing the qt/desktop part and shipping / adding > only the web part on fedora, It will work only via webpage > http://localhost/pgadmin4 , in the same way as phpMyAdmin does. I object that, but I was also considering adding another subpackage, and call it (for example) pgadmin4-desktop, so that it will only pull desktop components. Regards, Devrim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
