https://bugzilla.redhat.com/show_bug.cgi?id=1567202 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - That's not good: #Source0: https://github.com/gerbera/gerbera/archive/v%%{version}/%%{name}-%%{version}.tar.gz #Use tarball to address build issue. Source0: gerbera-1.1.0-2f6dcb5e94.tar.gz If you're packaging a snapshot, just use: %global commit 2f6dcb5e941dce3ace651394cfa86b862becaa77 %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global snapshotdate 20180413 Name: gerbera Version: 1.1.0 Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} Summary: UPnP Media Server License: GPLv2 Url: https://gerbera.io Source0: https://github.com/gerbera/gerbera/archive/{commit}/%{name}-%{commit}.tar.gz Then: %prep %autosetup -n %{name}-%{commit} And the %changelog: * Fri Apr 13 2018 Gwyn Ciesla <limburgher@xxxxxxxxx> - 1.1.0-1.20180413git2f6dcb5 - You're missing the dist tag: Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} - %{__make} %{?_smp_mflags} → %make_build - make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" → %make_install - %{__install}, %{__mkdir_p}, %{__cat} don't bring anything, just use install, mkdir -p and cat. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
