https://bugzilla.redhat.com/show_bug.cgi?id=1550595 --- Comment #7 from Javier Martinez Canillas <fmartine@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > Thanks Lukas, I'm not a SELinux specialist so I didn't take this package, > I''ll finish the review now. > Thanks a lot for your review! > > - These are not needed as this is the default: > > %defattr(-,root,root,0755) > %attr(0644,root,root) > %attr(0644,root,root) > Ok. > > - The latest version of tpm2-abrmd is 1.3.1, please bump your package. > That version wasn't released yet when I proposed the package for review more than a month ago (my original plan was to get reviewed so I could have this and update the tpm2-abrmd package to 1.3.0). > - The version in the header and the %changeloq are mismatched: > > * Thu Mar 01 2018 Javier Martinez Canillas <javierm@xxxxxxxxxx> - 0.0.1-1 > > It should be 1.2.0-1 (or 1.3.1-1 when you update) Right, I thought that other packages were using their selinux_policyver in the %changelog but probably just got confused. I'll use the Version-Release instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
