Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: stardict https://bugzilla.redhat.com/show_bug.cgi?id=226433 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-04 00:16 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is not silent on RPM W: stardict non-conffile-in-etc /etc/gconf/schemas/stardict.schemas but this can be ignored. + source files match upstream. 23bbfd0a75baab5d0def5596f19b80cb stardict-3.0.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file handled correctly. + scrollkeeper scriptlet used. + Binary RPM stardict-3.0.0-4.fc8 -> Provides: advertisement.so stardict_espeak.so stardict_gucharmap.so stardict_html_parsedata.so stardict_man.so stardict_powerword_parsedata.so stardict_spell.so stardict_update_info.so stardict_wiki_parsedata.so stardict_xdxf_parsedata.so Requires: bonobo-activation >= 2.2.0 enchant espeak gucharmap libICE.so.6 libORBit-2.so.0 libSM.so.6 libX11.so.6 libart_lgpl_2.so.2 libatk-1.0.so.0 libbonobo >= 2.2.0 libbonobo-2.so.0 libbonobo-activation.so.4 libbonoboui-2.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.2) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdl.so.2 libenchant.so.1 libespeak.so.1 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgconf-2.so.4 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnome >= 2.2.0 libgnome-2.so.0 libgnomecanvas-2.so.0 libgnomeui >= 2.2.0 libgnomeui-2.so.0 libgnomevfs-2.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libgucharmap.so.6 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpopt.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libsigc++20 >= 2.0.17 libsigc-2.0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libz.so.1 rtld(GNU_HASH) + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review