https://bugzilla.redhat.com/show_bug.cgi?id=1562526 --- Comment #7 from Hiro Wakabayashi <hiwkby@xxxxxxxxx> --- Hello, Iwicki I would like to ask you to continue this review as it is if it is not a big problem because upstream currently declined my idea for a reasonable reason. I discussed about my idea with the upstream developer yesterday, but he said it was difficult to apply it because he wants to get its program to automatically print out its git commit hash to track down which version of the software a user is using for user support. I left notes in comments above the Source0: line to make tarball as mentioned in the following guideline though I still should continue to think about another idea to make the url not to be one of "Troublesome URLs". https://fedoraproject.org/wiki/Packaging:SourceURL Thanks in advance. Memos: Code using git rev-parse command is here. https://github.com/yahoojapan/fullock/blob/master/make_rev.sh#L34 https://github.com/yahoojapan/fullock/blob/master/lib/Makefile.am#L41 But tarball from the following url doesn't contains .git directory. https://github.com/yahoojapan/fullock/archive/v1.0.24.tar.gz As a result, git rev-parse exit with nonzero status. https://git-scm.com/docs/git-rev-parse So I commented how to generate the tarball. https://github.com/hiwkby/fullock/blob/master/libfullock.spec#L10-L13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
