[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #36 from jiri vanek <jvanek@xxxxxxxxxx> ---
In addition,. I had checked the state of atk wrapper. It is dead. So i  will
remove the empty packages in addition...(In reply to Jie Kang from comment #35)
> A few specific rpmlint errors I would like to address:
> 
> 
> ###
> java-openjdk.x86_64: W: incoherent-version-in-changelog 1:10.0.0.46-1
> ['1:10.0.0.46-7.fc27', '1:10.0.0.46-7']
> 
> Will the version be set to back to 1 for the package? Otherwise I'd like to
> see the changelog updated appropriately.

Yes it will.
> 
> ###
> java-openjdk-src.x86_64: W: spelling-error %description -l en_US subpackage
> -> sub package, sub-package, package's
> 
> s/subpackage/sub-package in spec file. There are 3 locations I think

hmmm. As you wish.
> 
> ###
> java-openjdk-src.x86_64: E: description-line-too-long C The java-openjdk-src
> subpackage contains the complete OpenJDK 10 class library source code for
> use by IDE indexers and debuggers.
> 
> Fedora wants description lines to be at most 79 characters. I think you use
> macros to build these. Can the description be split into multiple lines?

Well why. The 79 limitation is from 1979.  Yes, about 1% of people running
without X may suffer, but those do not use Java. They are still on frontran.
Unless you insists, I would like  to keep it as it is.
> 
> ###
> 
...
> 
> Maybe:
> 
> s/packages with debug on/debug packages
> s/compressed in single archive/compressed
> 
> Also summary has 'Documentation' while description has 'documentation'. This
> should be made consistent. Prefer 'documentation', ie. not capitalized.

Will be done. TY!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux