https://bugzilla.redhat.com/show_bug.cgi?id=1562632 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - FIX: There's a semicolon missing after Source, which prevents the SPEC to be parsed correctly: Source http://search.cpan.org/CPAN/authors/id/B/BR/BRICKER/%{pkgname}-%{version}.tar.gz - BuildRequires FIX: Please add missing buildrequires: - make - used in spec - perl(Carp) - lib/Config/Std.pm:69 - perl(Fcntl) - lib/Config/Std.pm:284 - perl(strict) - lib/Config/Std.pm:6 - perl(warnings) - lib/Config/Std.pm:7 URL and Source addresses are Ok. Source archive (SHA-256: b7709ff663bd279d264ab9c2f51e9e9588479a3367a8c4cfc18659c2a11480fe) is original. Ok. Summary verified from lib/Config/Std.pm. Ok. Description verified from lib/Config/Std.pm. Ok. License verified from lib/Config/Std.pm and README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-Config-Std.spec review-perl-Config-Std/results/perl-Config-Std-0.903-1.fc29.noarch.rpm review-perl-Config-Std/results/perl-Config-Std-0.903-1.fc29.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-Config-Std-0.903-1.fc29.noarch.rpm 20:40:30 drwxr-xr-x 2 root root 0 avril 1 20:36 /usr/share/doc/perl-Config-Std -rw-r--r-- 1 root root 2234 oct. 7 04:05 /usr/share/doc/perl-Config-Std/Changes -rw-r--r-- 1 root root 952 oct. 7 03:44 /usr/share/doc/perl-Config-Std/README drwxr-xr-x 2 root root 0 avril 1 20:36 /usr/share/licenses/perl-Config-Std -rw-r--r-- 1 root root 18598 oct. 6 18:41 /usr/share/licenses/perl-Config-Std/LICENSE -rw-r--r-- 1 root root 8698 avril 1 20:36 /usr/share/man/man3/Config::Std.3pm.gz drwxr-xr-x 2 root root 0 avril 1 20:36 /usr/share/perl5/vendor_perl/Config -rw-r--r-- 1 root root 34130 oct. 7 04:03 /usr/share/perl5/vendor_perl/Config/Std.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Config-Std-0.903-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(:VERSION) >= 5.7.0 1 perl(Carp) 1 perl(Class::Std) 1 perl(Fcntl) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p perl-Config-Std-0.903-1.fc29.noarch.rpm perl(Config::Std) = 0.903 perl(Config::Std::Block) perl(Config::Std::Comment) perl(Config::Std::Gap) perl(Config::Std::Hash) perl(Config::Std::Keyval) perl-Config-Std = 0.903-1.fc29 Binary provides are Ok. Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=25765014) Ok The package is in line with Fedora and Perl packaging guidelines. Please correct all 'FIX' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
