[Bug 1559388] Review Request: dep - Go dependency management tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1559388



--- Comment #4 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
> [!]: License file installed when any subpackage combination is installed.

$ rpm -qpl
/home/jchaloup/rpmbuild/RPMS/noarch/dep-devel-0.4.1-1.fc24.noarch.rpm | grep
license
/usr/share/gocode/src/github.com/golang/dep/hack/licenseok
/usr/share/gocode/src/github.com/golang/dep/hack/licenseok/main.go
/usr/share/licenses/dep-devel
/usr/share/licenses/dep-devel/LICENSE
/usr/share/licenses/dep-devel/PATENTS

$ rpm -qpl /home/jchaloup/rpmbuild/RPMS/x86_64/dep-0.4.1-1.fc24.x86_64.rpm |
grep license
/usr/share/licenses/dep
/usr/share/licenses/dep/LICENSE
/usr/share/licenses/dep/PATENTS


Both files has at least one file under /usr/share/licenses/dep directory.
Wondering why the fedora-review is not happy.

> - This is not needed, even on EPEL %license is defined:
>
> #define license tag if not already defined
> %{!?_licensedir:%global license %doc}

Removed

> - As Neal said, PATENTS file belongs in %license

PATENTS moved under %license tag.

Both spec and srpm updated. The same links stay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux