[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #6 from jiri vanek <jvanek@xxxxxxxxxx> ---
[] Package must own all directories that it creates.
   will be fixed.  Only /usr/lib/jvm should not be owned. it is owned by
japackage tools. Also I think it is mentioned somewher ein guidelines, but have
not found. Are you sure with generic /usr/share/ stuff?
Also I belive I own /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64 ....
at least it is listed for me...
[] %config files are marked noreplace or the reason is justified.
     Note: No (noreplace) in %config
    
/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/management/jmxremote.password.template
  This one realy do not deserves to be noreplace. It is config tempalte   

     %config
    
/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/accessibility.properties
  I had not marked this one, as it contains generated path and shold be fully
contorlled by packager. Unluvkily, the only palce where jdk founds it is conf.

Same for debug variants.

[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in java-openjdk, java-openjdk-debug

It is, inst it?


[!]: Uses parallel make %{?_smp_mflags} macro.
I do not dare to use this flag. The build of OJDK is to complex to set anything
on top.

[!]: Spec use %global instead of %define unless justified.
This is major thing, and cant be fixed. The Usage of %global on top of %define
is  wrongly interpreted in fedora. If you change any of highlighted define to
global, the build will misbehave for you. This rpmlint was invalidated in f27
and  RPM 4.14. I will try to find the chnageset and bugzilla which made me to
change those selected globals back to defines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux