[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Just a few preliminary remarks.

 - Not needed:
    - Group:
    - BuildRoot: %{_tmppath}/%{name}-v%{version}-root
    - %{__rm} -rf %{buildroot}
    - %clean
      %{__rm} -rf %{buildroot}
    - %defattr(-,root,root,-)

 - /usr/share/mew/ → %{_datadir}/mew/

 - Split the description lines to stay below 80 characters per line

 - No need to use macros for %{__install} and %{__cp}

 - Don't put this in the summary: Package maintained by Rene Jr Purcell.

 - Summary shouldn't end with a dot

 - The correct shorthand for MIT is MIT, not "MIT License". See
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses for
a list of valid licenses.

 - Don't depend on Firefox, let the user choose whatever browser they want

 - Latest version is v3.21.02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux