Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pixel - CL web image gallery generator with JavaScript viewer Alias: px-review https://bugzilla.redhat.com/show_bug.cgi?id=261801 ------- Additional Comments From lkundrak@xxxxxxxxxx 2007-08-31 10:35 EST ------- * http://www.bx.cz/px-0-8.noarch.rpm is a built package, please include the src.rpm. * Release: 8 -- please change this to 8%{?dist}, as described in [1] * Source: %{name}.tar.gz -- it would be great if the source code tarball name contained the version. Even better if it you made it available for download somewhere in Internet (people.redhat.com?) * BuildRoot: %{_tmppath}/build-root-%{name} -- The standard build root form is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Packager: Josef Kubin <jkubin redhat com> -- This tag is obsolete, as usually multiple people work on a package. The authoritative source where to look for the names of people that worked on a package is the ChangeLog * License: GPL -- This is no longer acceptable. Please use specific version, such as GPLv3 or GPLv2+. See the Licensing FAQ [2] * Prefix: %{_datadir}/px -- please note that making relocatable packages is discouraged. See paragraph "Relocatable packages" in the Guidelines [1] * The changelog time stamp lines should end with complete version-release pair, e.g. 0-1, 0-2, 0-3 in your case. Each changelog entry should correspond to a revision. [1] http://fedoraproject.org/wiki/Packaging/Guidelines [2] http://fedoraproject.org/wiki/Licensing/FAQ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review