https://bugzilla.redhat.com/show_bug.cgi?id=1557766 Iwicki Artur <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> --- >Source0: https://github.com/BLAKE2/libb2/archive/%{checkout}.zip#/libb2-%{checkout}.zip Use "archive/%{checkout}/libb2-%{checkout}.zip" instead. As a minor nitpick - I think "%{git_commit}" is a more common name for this macro. >Release: 1.%{date}git%(echo %{checkout} | cut -c-6)%{?dist} Please define a separate macro for this ("%global checkout_short" or whatever); it will help readability. You should also include the LICENSE file (add "%license LICENSE" to %files). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
