[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #27 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
Spec URL: http://www.jdekloe.nl/Fedora/eccodes-2.7.0-1-rev3/eccodes.spec
SRPM URL:
http://www.jdekloe.nl/Fedora/eccodes-2.7.0-1-rev3/eccodes-2.7.0-1.fc27.src.rpm

Thanks again for looking at my changes.

(In reply to Robert-André Mauchin from comment #26)
> Seems upstream believe that the LGPL files are errors, and thus the whole
> project should be ASL 2.0.

changed it back again.

>  - This:
> 
> /usr/share/eccodes/cmake/eccodes-config-version.cmake
> /usr/share/eccodes/cmake/eccodes-config.cmake
> /usr/share/eccodes/cmake/eccodes-import.cmake
> /usr/share/eccodes/cmake/eccodes-targets-relwithdebinfo.cmake
> /usr/share/eccodes/cmake/eccodes-targets.cmake
> 
>    I think these files should be in %{_libdir}/cmake/%{name}/. And in the
> -devel subpackage.

done

>  - Your check part is escaped:
> 
> %%check
> 
>    Remove the extraneous %.

Sorry about that, stupid mistake from my side
fixed it.

New version in the URLs mentioned above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux