[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #20 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #19)
> 
> Final remarks:
> 
> - The wrong "BR: python-devel" and "BR: python-setuptools" are still there,
> I assume you just missed them in the last round. Please change the
> BuildRequires to python2-devel and python2-setuptools before importing.
> 

Yep, missed those. Fixed.

> - The wrong shebang in the kiwi/xml_parse.py file is still present. Please
> remove the shebang line with sed or add a patch to remove the line,
> otherwise the automatic shebang mangling will do the wrong thing eventually.
> 

Fixed.

> Please just update the .spec file (no srpm or scratch build necessary,
> though) for those two issues one last time - since these really _are_
> blocking issues by definition ("MUST NOT" items from the guidelines ... [0],
> [1]).
> 
> [0]: http://fedoraproject.org/wiki/Packaging:Python#Dependencies
> [1]: http://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

Done. New stuff below.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728888-kiwi/kiwi.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728888-kiwi/kiwi-9.13.7-0.fc29.4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux