https://bugzilla.redhat.com/show_bug.cgi?id=1551339 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: 91889c277e9c7dd470abf017ac73c02ab2a95aac355de4dd7c77f0c7fadef31d) is original. Ok. No XS code, noarch BuildArch is Ok. Summary is Ok. Description is Ok. License verified from shelldap. Ok. TODO: Remove useless %debug_package redefinion. Noarch packages are exempt from of debuginfo generation automatically. TODO: You can also use %{name} in the URL instead of the `shelldap'. TODO: You can also use %{url} in the Source0 instead of the same prefix. TODO: Replace BuildArchitectures tag with BuildArch. BuildArch is more prevalent in Fedora spec files and making spec files similar makes them easier to understand. FIX: Build-require `sed' (shelldap.spec:25). FIX: Build-require `coreutils' (shelldap.spec:29). FIX: Build-require `gawk' (shelldap.spec:29). TODO: Using perl instead of sed, tail, and awk could free you from these build-tie dependencies. TODO: Package CONTRIBUTORS file as a documentation. No tests. Ok. $ rpmlint shelldap.spec ../SRPMS/shelldap-1.4.0-1.fc29.src.rpm ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm -rwxr-xr-x 1 root root 55555 Mar 15 11:10 /usr/bin/shelldap drwxr-xr-x 2 root root 0 Mar 15 11:10 /usr/share/doc/shelldap -rw-r--r-- 1 root root 4091 Jun 8 2017 /usr/share/doc/shelldap/CHANGELOG -rw-r--r-- 1 root root 2663 Jun 8 2017 /usr/share/doc/shelldap/README.md drwxr-xr-x 2 root root 0 Mar 15 11:10 /usr/share/licenses/shelldap -rw-r--r-- 1 root root 1577 Mar 15 11:10 /usr/share/licenses/shelldap/LICENSE.txt -rw-r--r-- 1 root root 5898 Mar 15 11:10 /usr/share/man/man1/shelldap.1.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl(Algorithm::Diff) 1 perl(base) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Digest::MD5) 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(Net::LDAP) 1 perl(Net::LDAP::Control::Paged) 1 perl(Net::LDAP::Extension::SetPassword) 1 perl(Net::LDAP::LDIF) 1 perl(Net::LDAP::Util) 1 perl(Pod::Usage) 1 perl(strict) 1 perl(Term::ReadKey) 1 perl(Term::Shell) 1 perl(vars) 1 perl(warnings) 1 perl(YAML::Syck) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --recommends -p ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(Authen::SASL) 1 perl(IO::Socket::SSL) 1 perl(Term::ReadLine::Gnu) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm | sort -f | uniq -c 1 shelldap = 1.4.0-1.fc29 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/shelldap-1.4.0-1.fc29.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=25720229). Ok. Otherwise the package is in-line with Fedora packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
