https://bugzilla.redhat.com/show_bug.cgi?id=1548761 --- Comment #16 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- FYI: - https://github.com/jarun/nnn/pull/96 - https://github.com/jarun/nnn/issues/97 This looks overall good but I disagree with adding `Requires: bash-completion` because nnn will work fine without this package. Considering that bash is the default shell on Fedora, `Recommends:` would be more appropriate. >From the packaging guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership See the example "The directory is owned by a package which is not required for your package to function" and its solution: > The evolution package should own the /usr/share/gtk-doc directory. There is no need to add an explicit Requires on gtk-doc solely for the directory ownership. Since you need the ownership of both directories, sub-directories and finally completion scripts, you can simplify your %files list by omitting the %dir entries: -%{_datadir}/bash-completion/completions/nnn-completion.bash +%{_datadir}/bash-completion -%dir %{_datadir}/fish -%dir %{_datadir}/fish/vendor_functions.d -%dir %{_datadir}/fish +%{_datadir}/fish -%dir %{_datadir}/zsh -%dir %{_datadir}/zsh/site-functions -%{_datadir}/zsh/site-functions/_nnn +%{_datadir}/zsh The latter is only a suggestion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
