https://bugzilla.redhat.com/show_bug.cgi?id=1548761 Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #14 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. The LICENSE file looks more like BSD than GPLv3+. [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/bash-completion, /usr/share/fish, /usr/share/bash-completion/completions, /usr/share/zsh [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(nethogs, <snip> /usr/share/fish/vendor_functions.d(fish), /usr/share/zsh/site- functions(systemd, task, vcsh, pulseaudio, arch-install-scripts, curl, zsh), /usr/lib/.build-id/9d(mlt, open-vm-tools, man-db, kbd, <snip> rust, grub2-tools) You should own the following directories since their original packages are not hard dependencies and nnn can work even if they aren't installed: - /usr/share/bash-completion - /usr/share/bash-completion/completions - /usr/share/fish - /usr/share/zsh - /usr/share/fish/vendor_functions.d https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines The package lacks a manual page for the nlay program (SHOULD), but otherwise complies with all MUST items except the ones noted above. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Manpages [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nnn- debuginfo , nnn-debugsource [x]: Package functions as described. Tested manually on x86_64 inside the mock root. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=25689296 [-]: %check is present and all tests pass. No test suite upstream. [!]: Packages should try to preserve timestamps of original installed files. Upstream makefile hardcodes `install`. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nnn-1.7-1.fc29.x86_64.rpm nnn-debuginfo-1.7-1.fc29.x86_64.rpm nnn-debugsource-1.7-1.fc29.x86_64.rpm nnn-1.7-1.fc29.src.rpm nnn.x86_64: W: spelling-error %description -l en_US favourite -> favorite, favoritism nnn.x86_64: W: spelling-error %description -l en_US noice -> nice, notice, novice nnn.x86_64: W: spelling-error %description -l en_US cd -> CD, dc, Cd nnn.x86_64: W: spelling-error %description -l en_US chdir -> chair, choir nnn.x86_64: W: only-non-binary-in-usr-lib nnn.x86_64: W: no-manual-page-for-binary nlay nnn-debugsource.x86_64: W: no-documentation nnn.src: W: spelling-error %description -l en_US favourite -> favorite, favoritism nnn.src: W: spelling-error %description -l en_US noice -> nice, notice, novice nnn.src: W: spelling-error %description -l en_US cd -> CD, dc, Cd nnn.src: W: spelling-error %description -l en_US chdir -> chair, choir 4 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: nnn-debuginfo-1.7-1.fc29.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nnn.x86_64: W: spelling-error %description -l en_US favourite -> favorite, favoritism nnn.x86_64: W: spelling-error %description -l en_US noice -> nice, notice, novice nnn.x86_64: W: spelling-error %description -l en_US cd -> CD, dc, Cd nnn.x86_64: W: spelling-error %description -l en_US chdir -> chair, choir nnn.x86_64: W: invalid-url URL: https://github.com/jarun/nnn <urlopen error [Errno -2] Name or service not known> nnn.x86_64: W: only-non-binary-in-usr-lib nnn.x86_64: W: no-manual-page-for-binary nlay nnn-debugsource.x86_64: W: invalid-url URL: https://github.com/jarun/nnn <urlopen error [Errno -2] Name or service not known> nnn-debugsource.x86_64: W: no-documentation nnn-debuginfo.x86_64: W: invalid-url URL: https://github.com/jarun/nnn <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- nnn (rpmlib, GLIBC filtered): /bin/bash libc.so.6()(64bit) libncursesw.so.6()(64bit) libreadline.so.7()(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) nnn-debugsource (rpmlib, GLIBC filtered): nnn-debuginfo (rpmlib, GLIBC filtered): Provides -------- nnn: nnn nnn(x86-64) nnn-debugsource: nnn-debugsource nnn-debugsource(x86-64) nnn-debuginfo: debuginfo(build-id) nnn-debuginfo nnn-debuginfo(x86-64) Source checksums ---------------- https://github.com/jarun/nnn/archive/v1.7/nnn-1.7.tar.gz : CHECKSUM(SHA256) this package : fbe26efbed8b467352f313b92f8617d873c8cf0209fb6377572cf8d1ddc2747c CHECKSUM(SHA256) upstream package : fbe26efbed8b467352f313b92f8617d873c8cf0209fb6377572cf8d1ddc2747c Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1548761 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
