https://bugzilla.redhat.com/show_bug.cgi?id=1551402 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: + Package builds and installs successfully + Package follows guidelines on naming + Licensing is appropriately marked and license files are correctly installed + Macros are correctly and consistently used + Patches are well documented + Handling of desktop files and AppStream data is per guidelines ! Ownership of icon file directories is not known ambiguous due to lack of "Requires: hicolor-icon-theme". However, the one issue is minor, and historically we've not directly mandated it. I'd appreciate if the Requires was added on import, but I'm not going to block this review any further. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
