https://bugzilla.redhat.com/show_bug.cgi?id=1553496 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- 1 Review per bug, please open 3 bugs if you have 3 packages to review. - Not needed in Fedora: - Group: - BuildRoot: %{_tmppath}/%{name}-%{version}-build - %defattr(-,root,root) - If you install libraries, you must run %ldconfig_scriptlets after %install instead of: %post -n %{name}1 -p /sbin/ldconfig %postun -n %{name}1 -p /sbin/ldconfig - What do you create a "%{name}1" subpackage? This is useless, putthe files in the main package. - Release must start at 1 and contains %{?dist}: Release: 1%{?dist} - Not needed: %{!?_udevrulesdir: %global _udevrulesdir %(pkg-config --variable=udevdir udev)/rules.d } - Don't mix SUSE stuff in a Fedora package - %config → %config(noreplace) - Not needed: %post %{?udev_rules_update:%udev_rules_update} %postun %{?udev_rules_update:%udev_rules_update} - Source0: must be an URL pointing to the upstream archive. For ex: Source0: https://github.com/kochstefan/usbauth-all/archive/v%{version}/%{name}-%{version}.tar.gz - License: LGPL-2.1 License: GPL-2.0 These are not valid license shourthand. See the list of valid license: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses - Changelog must not be empty. - See https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation for how to add users and groups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
