https://bugzilla.redhat.com/show_bug.cgi?id=1551339 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@xxxxxxxxxx --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- The perl-* dependencies are wrong. We specify dependencies on Perl modules. Not on Perl packages. This is because the modules quite often moves between them. E.g. if shelldap script does "use Net::LDAP::Util" on line 467, then we write "Requires: perl(Net::LDAP::Util)" instead of "Requires: perl-LDAP". And actually you don't have to write the Perl run-time dependencies by hand. If you build-required perl-generators, then most of the Perl dependencies would be discovered and recorded into the binary package automatically. Also the shellbang fix is suboptimal as it hard codes /usr/bin instead of %{_bindir} as you uses in the %files section. This command provides the correct value retrieved from the perl itself: perl -MConfig -e 'print qq{$Config{startperl}\n}' To use this command, you should build-require `perl-interpreter' and `perl(Config)'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
