https://bugzilla.redhat.com/show_bug.cgi?id=1542654 --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Matěj Týč from comment #1) > gtk-update-icon-cache should be invoked in %postun and %posttrans > This is another false positive, it's not required any more: https://pagure.io/packaging-committee/issue/736 > Please change the versioning metadata so it is in sync with libquentier: > > Version: 0 > > to > > Version: 0.4 > > and > > Release: 1.%{commitdate}.git%{shortcommit}%{?dist} > > to > > Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist} > It depends what the upstream version currently is which is not clear, I found: 0.4.0 in: CMakeLists.txt, so if it's what upstream intended, the version tag should be: Version: 0.4.0 In https://github.com/d1vanov/quentier/releases it seems the 0.4.0 is still pre-release, if it's what the upstream intended then the release tag should be: Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist} Also I noticed, it seems it's bundling oxygen and tango themes icons, please unbundle and use icons from the installed themes (which should be added as dependency to the spec). I.e. regarding oxygen it generates qrc_oxygen.cpp from the bundled icons, which is cca. 23 MB in size. It's compiled to cca. 4.5 MB object file qrc_oxygen.cpp.o which is later linked to the final binary. Similarly for the tango theme. If unbundled the final stripped binary needn't have cca. 11 MB in size. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
