https://bugzilla.redhat.com/show_bug.cgi?id=1507103 --- Comment #80 from digimer <digimer@xxxxxxxxxx> --- Fixed comments. As an aside for later; When talking to people on #fedora-devel, it was recommended *not* to use 'BuildRequires: pkgconfig(x)', despite the package guidelines recommending it, as it is more ambiguous. The example given was: ==== issue occurs when various providers exists, ex: pkgconfig(openssl) mays pull openssl-devel or compat-openssl10-devel (the second being a terrible choice) ==== I don't want to hold up the approval process, but I wanted to bring this up as a possible change later. Thoughts? New .spec and srpm: https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.1-7 https://www.alteeve.com/an-repo/files/packages/kronosnet-1.1-7.fc27.src.rpm f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=25535007 f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=25535014 f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=25535022 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=25535030 epel7: https://koji.fedoraproject.org/koji/taskinfo?taskID=25535038 Diff from 1.1-6: ==== --- kronosnet.spec.1.1-6 2018-03-07 01:19:35.321125418 -0500 +++ kronosnet.spec.1.1-7 2018-03-07 01:50:40.831722937 -0500 @@ -70,7 +70,7 @@ Name: kronosnet Summary: Multipoint-to-Multipoint VPN daemon Version: 1.1 -Release: 6%{?dist} +Release: 7%{?dist} License: GPLv2+ and LGPLv2+ URL: http://www.kronosnet.org Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz @@ -310,6 +310,13 @@ Please refer to the not-yet-existing documentation for further information. +# libknet.pc leading to pkgconfig(libknet) automatic virtual provides, +# like other files, is not explicitly versioned in the name like the +# subpackages are -- intention of doing so for subpackage names is +# to ease the cross-checking the compatibility of the remote clients +# interchanging data using this network communication library, as +# the number denotes the protocol version (providing multiple +# protocol versions in parallel is not planned). %files -n libknet1-devel %{_libdir}/libknet.so %{_includedir}/libknet.h @@ -458,17 +465,15 @@ %files -n libknet1-plugins-all %if %{with rpmdebuginfo} -# libknet.pc leading to pkgconfig(libknet) automatic virtual provides, -# like other files, is not explicitly versioned in the name like the -# subpackages are -- intention of doing so for subpackage names is -# to ease the cross-checking the compatibility of the remote clients -# interchanging data using this network communication library, as -# the number denotes the protocol version (providing multiple -# protocol versions in parallel is not planned). +# This is left over from upstream. %debug_package %endif %changelog +* Wed Mar 07 2018 Madison Kelly <mkelly@xxxxxxxxxx> - 1.1-7 +- Moved the comment back above '%%files -n libknet1-devel'. +- Added comment to '%%debug_package'. + * Wed Mar 07 2018 Madison Kelly <mkelly@xxxxxxxxxx> - 1.1-6 - Added a version requirement to lz4 to deal with koji pulling in the wrong package. ==== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
