[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1550317

Randy Barlow <rbarlow@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(itamar@ispbrasil.
                   |                            |com.br)



--- Comment #4 from Randy Barlow <rbarlow@xxxxxxxxxx> ---
A few issues to fix:

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.6/site-
     packages/flask_security/templates/security/email, /usr/lib/python3.6
     /site-packages/flask_security/templates, /usr/lib/python3.6/site-
     packages/flask_security/translations, /usr/lib/python2.7/site-
     packages/flask_security/templates, /usr/lib/python3.6/site-
     packages/flask_security/__pycache__, /usr/lib/python2.7/site-
     packages/flask_security/translations, /usr/lib/python2.7/site-
     packages/flask_security/templates/security/email, /usr/lib/python2.7
     /site-packages/flask_security, /usr/lib/python2.7/site-
     packages/flask_security/templates/security, /usr/lib/python3.6/site-
     packages/flask_security/templates/security, /usr/lib/python3.6/site-
     packages/flask_security
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.6/site-
     packages/flask_security/templates/security/email, /usr/lib/python3.6
     /site-packages/flask_security/templates, /usr/lib/python3.6/site-
     packages/flask_security/__pycache__, /usr/lib/python2.7/site-
     packages/flask_security/templates, /usr/lib/python2.7/site-
     packages/flask_security/translations, /usr/lib/python2.7/site-
     packages/flask_security/templates/security/email, /usr/lib/python2.7
     /site-packages/flask_security, /usr/lib/python3.6/site-
     packages/flask_security/translations, /usr/lib/python2.7/site-
     packages/flask_security/templates/security, /usr/lib/python3.6/site-
     packages/flask_security/templates/security, /usr/lib/python3.6/site-
     packages/flask_security

Recommendation: Simply put %{python2_sitelib}/flask_security and
%{python3_sitelib}/flask_security into your %files sections, rather than trying
to write out all the subpaths.


[!]: You have
     %{?python_provide:%python_provide python%{python3_pkgversion}-%{pkg_name}}
     in the Python 2 subpackage.

Recommendation: It should be %{?python_provide:%python_provide
python2-%{pkg_name}}.


Optional, but recommended: Upstream does have a test suite. I recommend running
it in a %check section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux