https://bugzilla.redhat.com/show_bug.cgi?id=1542651 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to leigh scott from comment #1) > You have missing scriptlet, please add > > %ldconfig_scriptlets > > Done > Also it might be better to change > > BuildRequires: cmake > > and > > %cmake > > to > > BuildRequires: cmake3 > > and > > %cmake3 Not sure that this is necessary. cmake3 is provided by the cmake package and it's only a symbolic ink to the cmake executable. %cmake3 is identical to %cmake and use /usr/bin/cmake too. (In reply to leigh scott from comment #2) > Also the package versioning is wrong. > > Change from > > Version: 0 > > to > > Version: 0.4 > > > see cmake file > > if("${CMAKE_MAJOR_VERSION}" GREATER "2") > project(libquentier > VERSION 0.4.0) > else() > project(libquentier) > set(PROJECT_VERSION_MAJOR "0") > set(PROJECT_VERSION_MINOR "4") > > > And as 0.4.0 is an un-release version use 0.1 > > > change from > > > Release: 1.%{commitdate}.git%{shortcommit}%{?dist} > > to > > Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist} > > > and fix the changelog to suit Done. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/2f49996/libquentier.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00724600-libquentier/libquentier-0.4.0-0.3.20180301git4ce8e3b.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
