https://bugzilla.redhat.com/show_bug.cgi?id=1551402 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review notes: > %{cmake_kf5} .. We don't typically do braces around command macros. It doesn't hurt it in this case (since it's not parameterized), but in the future, avoid this, as command macros may be parameterized and this wouldn't work as intended > %post > /sbin/ldconfig > touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > %postun > /sbin/ldconfig > if [ $1 -eq 0 ] ; then > touch --no-create %{_datadir}/icons/hicolor &>/dev/null > gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > fi > > %posttrans > gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : Drop all the scriptlets here and replace with %ldconfig_scriptlets. The icon cache scriptlets has been replaced with a file trigger since Fedora 26, and the ldconfig execution should be using %ldconfig_scriptlets as it should be a no-op on F28+ and will work properly for <F28. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
