[Bug 1550319] Review Request: python-flask-gravatar - This is small and simple integration gravatar into flask.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1550319



--- Comment #6 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hi Itamar,

There are still some changes pending:

1) Remove the Provides on the unversioned python packages, those go against
Python packaging guidelines.

2) The pypi URL does not contain the sources for version 0.5.0, you want to get
that from github [1] (you can substitute the tag after 'archive for %{version}
to make your life easier in the future).

  Could not download Source0:
    
https://pypi.python.org/packages/b3/7c/162f5b98b88d2088a1a451ae4a354c725c700246ae69cb8cc26175508e65
     /Flask-Gravatar-0.5.0.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

3) In lines 54 and 62, under the %files sections, you are listing a directory.
Those line mean "package this directory AND everything under it". But then you
list specific files under those directories again. This leads to the following
warning:


  Note: BUILDSTDERR: warning: File listed twice: /usr/lib/python2.7/site-
  packages/flask_gravatar/__init__.py
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

To solve the issue, append "%dir" to the beginning of lines 54 and 62.

4) Remove the "." from the end of the Summary.

[1]
https://github.com/zzzsochi/Flask-Gravatar/archive/v0.5.0/Flask-Gravatar-0.5.0.tar.gz

Here is the rpmlint output:


Rpmlint
-------
Checking: python2-flask-gravatar-0.5.0-1.fc28.noarch.rpm
          python3-flask-gravatar-0.5.0-1.fc28.noarch.rpm
          python-flask-gravatar-0.5.0-1.fc28.src.rpm
python2-flask-gravatar.noarch: E: useless-provides python-flask-gravatar
python2-flask-gravatar.noarch: W: self-obsoletion python-flask-gravatar <
0.5.0-1.fc28 obsoletes python-flask-gravatar
python-flask-gravatar.src: W: summary-ended-with-dot C Small extension for
Flask to make usage of Gravatar service easy.
python-flask-gravatar.src:22: W: unversioned-explicit-provides
python-%{pkg_name}
python-flask-gravatar.src:31: W: unversioned-explicit-provides
python-%{pkg_name}
python-flask-gravatar.src: W: invalid-url Source0:
https://pypi.python.org/packages/b3/7c/162f5b98b88d2088a1a451ae4a354c725c700246ae69cb8cc26175508e65/Flask-Gravatar-0.5.0.tar.gz
HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 1 errors, 5 warnings.


Rpmlint (installed packages)
----------------------------
python2-flask-gravatar.noarch: W: invalid-url URL:
http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or
service not known>
python2-flask-gravatar.noarch: E: useless-provides python-flask-gravatar
python2-flask-gravatar.noarch: W: self-obsoletion python-flask-gravatar <
0.5.0-1.fc28 obsoletes python-flask-gravatar
python3-flask-gravatar.noarch: W: invalid-url URL:
http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or
service not known>
2 packages and 0 specfiles checked; 1 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux